Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
|
|
product-security-plaid-production
Bot
requested review from
ChrisAmora and
vyzaldysanchez
amit-momin
previously approved these changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Risk Rating: MEDIUM
This PR bumps github.com/smartcontractkit/chainlink-solana across the repo and aligns Chainlink’s Solana workflow configuration (docs/testdata/tests) with the updated Solana relayer/config expectations.
Changes:
- Bump
github.com/smartcontractkit/chainlink-solanatov1.1.2-0.20260427183309-13341c01b05dacross multiple Go modules and plugin metadata. - Remove Solana workflow forwarder/from-address fields from docs and TOML test fixtures.
- Update Solana relayer wiring to pass the keystore into the embedded relayer constructor and adjust system-test Solana TOML patching accordingly.
Reviewed changes
Copilot reviewed 19 out of 26 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Bumps root chainlink-solana dependency. |
| go.sum | Updates checksums for bumped chainlink-solana. |
| deployment/go.mod | Bumps deployment module chainlink-solana dependency. |
| deployment/go.sum | Updates checksums for deployment module bump. |
| integration-tests/go.mod | Bumps chainlink-solana dependency for integration tests. |
| integration-tests/go.sum | Updates checksums for integration tests bump. |
| integration-tests/load/go.mod | Bumps chainlink-solana dependency for load tests. |
| integration-tests/load/go.sum | Updates checksums for load tests bump. |
| system-tests/lib/go.mod | Bumps chainlink-solana dependency for system-tests lib. |
| system-tests/lib/go.sum | Updates checksums for system-tests lib bump. |
| system-tests/tests/go.mod | Bumps chainlink-solana dependency for system-tests tests module. |
| system-tests/tests/go.sum | Updates checksums for system-tests tests module bump. |
| core/scripts/go.mod | Bumps chainlink-solana dependency for core scripts module. |
| core/scripts/go.sum | Updates checksums for core scripts module bump. |
| plugins/plugins.public.yaml | Updates Solana plugin gitRef to the new version. |
| core/services/chainlink/relayer_factory.go | Passes keystore into embedded Solana relayer constructor. |
| system-tests/lib/cre/features/solana/v2/solana.go | Removes forwarder/from-address injection into Solana.Workflow TOML patching. |
| core/services/chainlink/config_test.go | Updates config marshal test to match Solana workflow config field removals. |
| docs/CONFIG.md | Removes Solana workflow forwarder/from-address docs entries. |
| core/config/docs/chains-solana.toml | Removes Solana workflow forwarder/from-address example config entries. |
| core/scripts/cre/environment/configs/capability_defaults.toml | Removes comments referencing runtime-injected Solana workflow values that no longer apply. |
| core/web/resolver/testdata/config-multi-chain-effective.toml | Removes Solana workflow forwarder/from-address keys from effective config fixture. |
| core/web/resolver/testdata/config-full.toml | Removes Solana workflow forwarder/from-address keys from full config fixture. |
| core/services/chainlink/testdata/config-multi-chain-effective.toml | Removes Solana workflow forwarder/from-address keys from effective config fixture. |
| core/services/chainlink/testdata/config-full.toml | Removes Solana workflow forwarder/from-address keys from full config fixture. |
| core/web/chains_controller_test.go | Updates test TOML snippet to match removed Solana workflow forwarder/from-address keys. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
I see you updated files related to
|
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
ilija42
approved these changes
Apr 27, 2026
ecPablo
approved these changes
Apr 27, 2026
Contributor
ecPablo
left a comment
ecPablo
left a comment
There was a problem hiding this comment.
approving /deployment module bumps
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
jmank88
requested changes
Apr 27, 2026
Contributor
There was a problem hiding this comment.
Is this a breaking config change?
Collaborator
Author
There was a problem hiding this comment.
yes, these config fields aren't used by any product currently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires
Supports